Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

horizontal↔︎ and vertical︎↕︎ #2147

Closed
wants to merge 1 commit into from
Closed

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Aug 23, 2024

closes #2146

(and it's also probably better for screen readers?)

before after
before after

@Fil Fil requested a review from mbostock August 23, 2024 09:43
@Fil Fil changed the base branch from main to fil/design-tweaks August 23, 2024 09:50
@Fil
Copy link
Contributor Author

Fil commented Aug 23, 2024

Alternative way of fixing this issue is to set --vp-font-family-base:

:root: {
  --vp-font-family-base: Inter, -apple-system, BlinkMacSystemFont, "avenir next", avenir, helvetica, "helvetica neue", ubuntu, roboto, noto, "segoe ui", arial, sans-serif;
}

instead of the defaults from VitePress:

'Inter', ui-sans-serif, system-ui, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol', 'Noto Color Emoji'

or maybe we do both?

@mbostock
Copy link
Member

I’m inclined to change the definition of --vp-font-family-base to minimize churn and for better consistency with the Framework docs. Also it’s more internally consistent as we also have many instances of right→, ←left, up↑, and down↓. Not sure why these don’t also render as right➡️, left⬅️, up⬆️, down⬇️… thinking🤔 shrug🤷.

@Fil
Copy link
Contributor Author

Fil commented Aug 23, 2024

ok 🤷🤷

@Fil Fil closed this Aug 23, 2024
@Fil Fil deleted the fil/emoji-text branch August 23, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vertical︎↕︎ is displayed with the emoji font-variant
2 participants