Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tip on a geo mark without a projection should not collapse the chart #1746

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Jul 10, 2023

fixes #1742

when adding tip: true on a geo mark, we create an initializer that generates new channels for the derived tip mark, typically geometry, and x and y if the geoCentroid transform or the centroid initializer were applied.

However:

  1. geometry is associated to the "projection" scale, resulting in the "collapsing" of x and y when considered as a new scale
  2. x and y, as produced by the centroid initializer, were not scaled

Demo: https://observablehq.com/@fil/geo-tip-true-1746

@Fil Fil force-pushed the fil/geo-collapse branch from 85da8d3 to b3e1318 Compare July 10, 2023 10:44
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mbostock mbostock enabled auto-merge (squash) July 11, 2023 16:57
@mbostock mbostock merged commit 39f1b72 into main Jul 11, 2023
@mbostock mbostock deleted the fil/geo-collapse branch July 11, 2023 16:59
Fil added a commit that referenced this pull request Aug 21, 2023
…1746)

* fix collapsing bug (#1742)

* avoid array.includes

---------

Co-authored-by: Mike Bostock <mbostock@gmail.com>
chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
…bservablehq#1746)

* fix collapsing bug (observablehq#1742)

* avoid array.includes

---------

Co-authored-by: Mike Bostock <mbostock@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plot.geo with tip: true collapses the chart
2 participants