Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The group transform should generate empty groups for extra values in the domain? #255

Closed
mbostock opened this issue Mar 18, 2021 · 2 comments
Closed

The group transform should generate empty groups for extra values in the domain? #255

mbostock opened this issue Mar 18, 2021 · 2 comments
Labels
bug Something isn’t working

Comments

@mbostock
Copy link
Member

Currently, the domain option can only be used to generate a subset of groups, but I think we also want to generate empty groups for any other values in the domain, and also we should respect the specified order of the domain rather than always sorting naturally.
@mbostock mbostock added the bug Something isn’t working label Mar 18, 2021
@Fil Fil self-assigned this Mar 23, 2021
Fil added a commit that referenced this issue Mar 24, 2021
@Fil
groups respect the domain option
ce588f2 
fixes #255
@Fil Fil mentioned this issue Mar 24, 2021
Closed
Fil added a commit that referenced this issue Mar 24, 2021
@Fil
groups respect the domain option fixes #255
96afbf6
@Fil Fil mentioned this issue Mar 24, 2021
Closed
@Fil Fil removed their assignment Mar 26, 2021
Fil added a commit that referenced this issue Mar 27, 2021
@Fil
compute the scaled coordinates of bars (and cell) before filtering, a…
d4733f3 
…llowing NaN, null and undefined as (ordinal) classes

groups respect the domain option

fixes #52
fixes #45
fixes #255
supersedes #272
Fil added a commit that referenced this issue Mar 27, 2021
@Fil
compute the scaled coordinates of bars (and cell) before filtering, a…
d98275a 
…llowing NaN, null and undefined as (ordinal) classes

groups respect the domain option

fixes #52
fixes #45
fixes #255
supersedes #271
@mbostock mbostock changed the title The group option should generate empty groups for extra values in the domain? The group transform should generate empty groups for extra values in the domain? Mar 28, 2021
@mbostock
Copy link
Member Author

The domain option was removed in #272; we’re going to set the scale’s domain instead, and then respect that in the group transform.

@mbostock
Copy link
Member Author

Er, we won’t respect it the group transform, I guess (because that happens prior to the scale’s domains being computed), but the resulting marks won’t be rendered when #52 is fixed.

Fil referenced this issue Apr 1, 2021
@mbostock
simplify example
650529a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn’t working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

groups respect the domain option observablehq/plot
fix group domain observablehq/plot
2 participants
@Fil @mbostock