Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Added quotes in cli for Windows PowerShell compatibility #986

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

danmarshall
Copy link
Contributor

Thanks for adding Windows support! 🎉🍻

In Windows Powershell (the default terminal for VSCode), the @ character is reserved, and the current command will only run npm init.

Thanks for adding Windows support! 🎉🍻

In Windows Powershell, the `@` character is reserved, and the current command will only run `npm init`.
@Fil
Copy link
Contributor

Fil commented Mar 6, 2024

wouldn't yarn create "@observablehq" work everywhere? (I'd prefer a single generic line than listing cases.)

Instead of special casing PowerShell, surrounding @observablehq with quotes works for all shells.
@danmarshall danmarshall changed the title Docs: Added cli for Windows PowerShell Docs: Added cli for Windows PowerShell compatibility Mar 6, 2024
@danmarshall danmarshall changed the title Docs: Added cli for Windows PowerShell compatibility Docs: Added quotes in cli for Windows PowerShell compatibility Mar 6, 2024
@danmarshall
Copy link
Contributor Author

@Fil fixed.

Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d like to find a way to hide these quotes via CSS on non-Windows (purely for aesthetics), but this is a fine place to start.

@mbostock mbostock enabled auto-merge (squash) March 6, 2024 18:34
@mbostock mbostock merged commit a1ffaff into observablehq:main Mar 6, 2024
4 checks passed
@danmarshall danmarshall deleted the patch-1 branch March 6, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants