Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bindplane_configuration): Lack of rollout options should not cause a change during apply #114

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented Aug 7, 2024

Description of Changes

Resolves #106

During Terraform plan | apply, configuration resources will attempt to make the following change when rollout_options are not specified.

Terraform will perform the following actions:

  # bindplane_configuration.configuration will be updated in-place
  ~ resource "bindplane_configuration" "configuration" {
        id                   = "01J4QENC1ZFCZ4A636AETS1990"
        name                 = "my-config"
        # (6 unchanged attributes hidden)

      - rollout_options {
            # (1 unchanged attribute hidden)
        }

        # (3 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Testing

Rollout options should be idempotent when no changes have been made. Test adding, removing, and modifying rollout options. Repeat applies should not suggest changes unless something has changed.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CI passes

@jsirianni jsirianni changed the title fix(bindplane_configuration): Lack of rollout options should not caus… fix(bindplane_configuration): Lack of rollout options should not cause a change during apply Aug 7, 2024
@jsirianni jsirianni marked this pull request as ready for review August 7, 2024 22:42
@jsirianni jsirianni requested a review from a team as a code owner August 7, 2024 22:42
@jsirianni jsirianni requested a review from tbm48813 August 7, 2024 22:42
@jsirianni jsirianni merged commit bd52dcb into main Aug 8, 2024
18 checks passed
@jsirianni jsirianni deleted the joesirianni/bpop-507-terraform-bindplane_configuration-rollout_options-idempotent branch August 8, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rollout_options does not allow empty value, when performing plan a change is detected
2 participants