Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bindplane_configuration): Implement measurement_interval option #103

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented Jul 17, 2024

Description of Changes

NOTE: Measurement interval is not supported until BindPlane v1.65.0. It is safe to use the field on older versions of BindPlane, it will be ignored.

Added a new measurement_interval option to the bindplane_configuration resource. This interval can be set to 10s, 1m, 15m and is constrained to thos values using a validation function.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CI passes

@jsirianni jsirianni marked this pull request as ready for review July 17, 2024 21:30
@jsirianni jsirianni requested a review from a team as a code owner July 17, 2024 21:30
@jsirianni jsirianni requested a review from tbm48813 July 18, 2024 13:30
@jsirianni jsirianni force-pushed the joesirianni/bpop-359-terraform-configurable-measurement-interval branch from 7512c9f to f1e0093 Compare July 24, 2024 18:40
@jsirianni jsirianni merged commit 1c93228 into main Jul 24, 2024
20 checks passed
@jsirianni jsirianni deleted the joesirianni/bpop-359-terraform-configurable-measurement-interval branch July 24, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants