Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use control-group KillMode in systemd config #2161

Conversation

dpaasman00
Copy link
Contributor

@dpaasman00 dpaasman00 commented Feb 11, 2025

Proposed Change

Need to use the value control-group for KillMode in the systemd service config. Linear ticket.

Testing:

  • Checkout this branch and run make clean, make install-tools, and make release-test
  • Get the relevant linux package (.rpm or .deb) on to your linux machine, as well as the script at scripts/install/install_unix.sh
  • Run the script on the linux machine with sudo ./install_unix.sh -f <path-to-linux-pkg> ... followed by the remaining argument flags to connect to a bindplane instance like -e and -s. Do not provide a version using -v
  • Roll a config out to the agent
  • Run systemctl status bindplane-otel-collector.service to see the collector and supervisor running
  • Stop the service with systemctl stop bindplane-otel-collector.service and rerun the status command to verify the collector is stopped
Checklist
  • Changes are tested
  • CI has passed

@dpaasman00 dpaasman00 requested a review from a team as a code owner February 11, 2025 16:56
@dpaasman00 dpaasman00 requested review from andykellr and jsirianni and removed request for andykellr February 11, 2025 16:56
@dpaasman00 dpaasman00 merged commit f320268 into release/v2.0.0 Feb 11, 2025
15 checks passed
@dpaasman00 dpaasman00 deleted the dakotapaasman/bpop-1678-v2-agent-runs-more-than-one-collector-sub-process branch February 11, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants