Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Added additional information in logging of collector rollouts #2155

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

BominRahmani
Copy link
Contributor

{
  "level":"info",
  "ts":"2024-09-25T11:31:29.779-0500",
  "logger":"config manager",
  "caller":"observiq/agent_config_manager.go:161",
  "msg":"Applying changes to config file",
  "config":"collector.yaml"
}

This log says specifies config:"collector.yaml" - it caused confusion with a customer. In short, the ConfigMap given by OpAMP calls this config "collector.yaml", but the actual config on-disk is "config.yaml". Might want to modify this somehow to reduce confusion (e.g. change key to opamp-config or confmap-config or something to specify that it's not the on-disk config. Including the on-disk config here might also help).

In essence this PR clarifies this by updating the log message.
Here is the updated log

{"level":"info","ts":"2025-02-10T11:12:57.615-0500","logger":"config manager","caller":"observiq/agent_config_manager.go:161","msg":"Applying changes to config file","OpAMPConfig":"collector.yaml","OnDiskCollectorConfig":"local/config.yaml"}

Proposed Change

Checklist
  • Changes are tested
  • CI has passed

@BominRahmani BominRahmani requested review from dpaasman00 and a team as code owners February 10, 2025 16:16
@BominRahmani BominRahmani force-pushed the fix/specify-collector-config-logging branch from 2beefbf to a63edf2 Compare February 11, 2025 18:31
@BominRahmani BominRahmani merged commit 7ccca92 into main Feb 11, 2025
15 checks passed
@BominRahmani BominRahmani deleted the fix/specify-collector-config-logging branch February 11, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants