feat: Add uninstall command to install script output (BPOP-1899) #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caleb-Hurshman
force-pushed
the
install-script-uninstall-command
branch
from
bb223c2 to
f38d251
Compare
Caleb-Hurshman
force-pushed
the
install-script-uninstall-command
branch
from
f38d251 to
849e2cc
Compare
dpaasman00
requested changes
Feb 5, 2025
internal/report/agent_client.go
Outdated
| @@ -65,7 +65,7 @@ func (a *AgentClient) Do(req *http.Request) (*http.Response, error) { | |||
| req.Header.Add("Agent-ID", a.agentID) | |||
|
|
|||
| if a.secretKey != nil { | |||
| req.Header.Add("X-BindPlane-Secret-Key", *a.secretKey) | |||
| req.Header.Add("X-Bindplane-Secret-Key", *a.secretKey) | |||
There was a problem hiding this comment.
This should not be changed right now
internal/report/agent_client_test.go
Outdated
| @@ -62,7 +62,7 @@ func TestAgentClientDo(t *testing.T) { | |||
| headerID := r.Header.Get("Agent-ID") | |||
| require.Equal(t, tc.agentID, headerID) | |||
|
|
|||
| secretKeyHeader := r.Header.Get("X-BindPlane-Secret-Key") | |||
| secretKeyHeader := r.Header.Get("X-Bindplane-Secret-Key") | |||
There was a problem hiding this comment.
This should not be changed right now
scripts/install/install_unix.sh
Outdated
Comment on lines
765
to
770
| info "Uninstall Command: $(fg_cyan "sudo systemctl observiq-otel-collector -r")$(reset)" | ||
| else | ||
| info "Start Command: $(fg_cyan "sudo service observiq-otel-collector start")$(reset)" | ||
| info "Stop Command: $(fg_cyan "sudo service observiq-otel-collector stop")$(reset)" | ||
| info "Status Command: $(fg_cyan "sudo service observiq-otel-collector status")$(reset)" | ||
| info "Uninstall Command: $(fg_cyan "sudo service observiq-otel-collector -r")$(reset)" |
There was a problem hiding this comment.
The uninstall commands here are just like the macos one but with the unix script...
Suggested change
| info "Uninstall Command: $(fg_cyan "sudo systemctl observiq-otel-collector -r")$(reset)" | |
| else | |
| info "Start Command: $(fg_cyan "sudo service observiq-otel-collector start")$(reset)" | |
| info "Stop Command: $(fg_cyan "sudo service observiq-otel-collector stop")$(reset)" | |
| info "Status Command: $(fg_cyan "sudo service observiq-otel-collector status")$(reset)" | |
| info "Uninstall Command: $(fg_cyan "sudo service observiq-otel-collector -r")$(reset)" | |
| info "Uninstall Command: $(fg_cyan "sudo sh -c "$(curl -fsSlL https://github.com/observIQ/bindplane-otel-collector/releases/latest/download/install_unix.sh)" install_unix.sh -r")$(reset)" | |
| else | |
| info "Start Command: $(fg_cyan "sudo service observiq-otel-collector start")$(reset)" | |
| info "Stop Command: $(fg_cyan "sudo service observiq-otel-collector stop")$(reset)" | |
| info "Status Command: $(fg_cyan "sudo service observiq-otel-collector status")$(reset)" | |
| info "Uninstall Command: $(fg_cyan "sudo sh -c "$(curl -fsSlL https://github.com/observIQ/bindplane-otel-collector/releases/latest/download/install_unix.sh)" install_unix.sh -r")$(reset)" |
updater/README.md
Outdated
|
|
||
| The updater is a separate binary that runs as a separate process to update agent artifacts (including the agent itself) when managed by [BindPlane OP](https://observiq.com/). | ||
| The updater is a separate binary that runs as a separate process to update agent artifacts (including the agent itself) when managed by [Bindplane OP](https://observiq.com/). |
There was a problem hiding this comment.
Suggested change
| The updater is a separate binary that runs as a separate process to update agent artifacts (including the agent itself) when managed by [Bindplane OP](https://observiq.com/). | |
| The updater is a separate binary that runs as a separate process to update agent artifacts (including the agent itself) when managed by [Bindplane](https://bindplane.com/). |
updater/README.md
Outdated
| @@ -47,4 +47,4 @@ In the event of update failure, you may look in the following places for more in | |||
|
|
|||
| * The agent produces logs in the log directory (by default, `$INSTALL_DIR/log/collector.log`). | |||
| * The updater produces logs in the agent's log directory, and is always set to log at a debug level (`$INSTALL_DIR/log/updater.log`). | |||
| * If the update was initiated through the BindPlane OP UI, an error message should be displayed in the UI. | |||
| * If the update was initiated through the Bindplane OP UI, an error message should be displayed in the UI. | |||
There was a problem hiding this comment.
Suggested change
| * If the update was initiated through the Bindplane OP UI, an error message should be displayed in the UI. | |
| * If the update was initiated through the Bindplane UI, an error message should be displayed in the UI. |
dpaasman00
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Display the command to uninstall the collector to the output of the installation script.
Change incorrect capitalizations of 'BindPlane' to the correct 'Bindplane'.
Checklist