-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add taxon constraints #2107
Add taxon constraints #2107
Conversation
This commit intends to 1. add taxon constraint `in taxon` *some* **Arthropoda** to some terms using a ROBOT template, 2. add taxon restriction annotation `never in taxon` **Mammalia** (NCBITaxon:40674) to some terms using another ROBOT template. If applied, this commit will address #2050. ### Notes * I had to delete the following 2 terms from the ROBOT template, because they cause OBO format `multiple name tags not allowed` errors: ``` UBERON:6003006 adult segment owl:Class ('in taxon' some Arthropoda) UBERON:6000154 embryonic segment owl:Class ('in taxon' some Arthropoda) ``` * I also had to delete the following term from the ROBOT template, because it appears to be obsolete and raises validation errors: ``` UBERON:6000000 embryonic germ layer derivative owl:Class ('in taxon' some Arthropoda) ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rays22
I see that checks have failed :-(
Assume your template doesn't add labels? |
Looking into this, the current version of Uberon (not the slim!) has |
As a reminder, the ROBOT templates should be applied to Uberon, not to the slim, right? |
Because we'd want taxon rules applied upstream. |
@rays22 - fail is presumably due to inconsistencies triggered by adding taxon constraints. This is a good thing as it will allow us to clean things up. Please paste a sample inconsistency report from robot (See other PR for how to do this) or Protege. Happy to help debug. Could meet briefly to discuss if you're still stuck. But not until tomorrow. |
Apparently it does... :( I can add these terms with another template, but first I need to check the QC errors. |
|
Please switch all templates to just 2 columns - SUBJECT and OBJECT
Sorry - should have been clearer. We need some inconsistency explanations. Nico added something on how to do this with Robot. In Protege Click the question mark on inferred subClassOf Nothing - present on inconsistent terms. |
Please, see the report attached to #2108 for the inconsistencies.
|
This commit intends to
in taxon
some Arthropoda to some termsusing a ROBOT template,
never in taxon
Mammalia (NCBITaxon:40674) to some terms using another ROBOT template.If applied, this commit will address #2050.
Notes
multiple name tags not allowed
errors: