Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): bind performance to support node 19+ #101

Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix(node): bind performance to support node 19+ #101

merged 1 commit into from
Oct 12, 2023

Conversation

mhassan1
Copy link
Contributor

This PR fixes the Node.js wrapper in isomorphic-performance to work in Node.js 19+, which added brand checks on performance in nodejs/node#44483.

Resolves #100.

@oblador oblador merged commit 1120087 into oblador:master Oct 12, 2023
6 checks passed
@oblador
Copy link
Owner

oblador commented Oct 12, 2023

Thanks for quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oblador oblador oblador approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: The "this" argument must be an instance of Performance. with Node.js 20
2 participants
@mhassan1 @oblador