-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android Fingerprint #195
Android Fingerprint #195
Changes from 31 commits
e988f29
46ce672
bac96c7
c67692f
27a463e
2e530de
14f9139
3052876
fa8b7ad
2c86afe
a11691c
795a487
8d5db02
315881d
fa2a294
3c44296
b1c97fa
fa57fc0
943333d
e18fe20
8886c35
632dd85
bce5332
17ccc09
0fa159c
24f83cc
c87bfc1
f4c1b81
c648d1b
af9254a
8ccf178
b77c278
5752483
3e985e2
a88b962
dce043c
1507676
4beddc6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,14 @@ | ||
buildscript { | ||
repositories { | ||
jcenter() | ||
maven { | ||
url 'https://maven.google.com/' | ||
name 'Google' | ||
} | ||
} | ||
|
||
dependencies { | ||
classpath 'com.android.tools.build:gradle:1.1.3' | ||
classpath 'com.android.tools.build:gradle:3.2.1' | ||
} | ||
} | ||
|
||
|
@@ -15,12 +19,12 @@ def safeExtGet(prop, fallback) { | |
} | ||
|
||
android { | ||
compileSdkVersion safeExtGet('compileSdkVersion', 28) | ||
buildToolsVersion safeExtGet('buildToolsVersion', '26.0.3') | ||
compileSdkVersion safeExtGet('compileSdkVersion', 28) | ||
buildToolsVersion safeExtGet('buildToolsVersion', '28.0.3') | ||
|
||
defaultConfig { | ||
targetSdkVersion safeExtGet('targetSdkVersion', 28) | ||
minSdkVersion safeExtGet('minSdkVersion', 16) | ||
targetSdkVersion safeExtGet('targetSdkVersion', 26) | ||
versionCode 1 | ||
versionName "1.0" | ||
} | ||
|
@@ -31,9 +35,16 @@ android { | |
|
||
repositories { | ||
mavenCentral() | ||
maven { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you can just use |
||
url 'https://maven.google.com/' | ||
name 'Google' | ||
} | ||
} | ||
|
||
dependencies { | ||
implementation 'com.facebook.react:react-native:+' | ||
implementation 'com.facebook.conceal:conceal:1.1.3@aar' | ||
implementation 'com.android.support:support-v4:27.0.2' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we should align to version 28.0.0 - it guaranty that androidx with jetifier tool will be without any problems. |
||
implementation 'com.facebook.react:react-native:+' | ||
implementation 'com.facebook.conceal:conceal:1.1.3@aar' | ||
implementation 'android.arch.lifecycle:runtime:1.1.0' | ||
annotationProcessor 'android.arch.lifecycle:compiler:1.1.0' | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
#Wed Oct 21 11:34:03 PDT 2015 | ||
#Sun Oct 21 15:04:55 BST 2018 | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-2.8-all.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-4.6-all.zip | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 5.6.2 is the latest |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,6 @@ | ||
<manifest xmlns:android="http://schemas.android.com/apk/res/android" | ||
package="com.oblador.keychain"> | ||
<uses-permission android:name="android.permission.USE_FINGERPRINT" /> | ||
|
||
<uses-permission android:name="android.permission.USE_BIOMETRIC" /> | ||
<uses-permission android:name="android.permission.USE_FINGERPRINT" /> | ||
</manifest> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can just use
google()
, and ideally put it to the top