feat(#49): package-without-tail lint #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxonfjvipon please check |
maxonfjvipon
suggested changes
Dec 27, 2024
| <xsl:if test="/program/metas/meta[head = 'package' and tail = '']"> | ||
| <xsl:element name="defect"> | ||
| <xsl:attribute name="line"> | ||
| <xsl:text>0</xsl:text> |
There was a problem hiding this comment.
@h1alexbel is there a way we can put a real line number where package meta is located? Please check this file at the line 151 we add line to meta. Let's use it?
|
@maxonfjvipon updated. Take a look, please |
maxonfjvipon
approved these changes
Dec 27, 2024
|
@yegor256 take a look, please |
|
@h1alexbel thanks! |
|
@h1alexbel Thanks for the contribution! You've earned +4 points for this: +4 as a basis; +6 for the 123 hits-of-code that you wrote; -16 for the lack of code review; -4 for very few (4) comments; +14 to give you at least something. Please, keep them coming. Your running balance is +16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull, I've introduced new lint:
package-without-tailthat issuescriticaldefect if+packagemeta is used without a tail.closes #49