incorrect-version Check Throws False Negative Error for 1.0-SNAPSHOT

[volodya-lombrozo]

XMIR might be generated from any source (not only from EO), by this reason sometimes we can generate XMIR by using jeo-maven-plugin:1.0-SNAPSHOT. Pay attention to the version 1.0-SNAPSHOT - it's correct semver version.

Semver BNF (part):

<valid semver> ::= <version core>
                 | <version core> "-" <pre-release>
                 | <version core> "+" <build>
                 | <version core> "-" <pre-release> "+" <build>

You can read more about it here: https://semver.org

But for the version 1.0-SNAPSHOT I'm getting the following error:

XMIR is incorrect: [[incorrect-version WARNING]:0 The format of the +version meta is wrong: "1.0-SNAPSHOT" (SemVer expected instead)], 

Please, remove this check or fix it.

[volodya-lombrozo]

@yegor256 Could you have a look, please? It blocks: objectionary/jeo-maven-plugin#962

[volodya-lombrozo]

Well, with 0.1.0-SNAPSHOT version it works fine. So, actually 1.0-SNAPSHOT doesn't follow semver according with BNF I send before. My bad. I need to change the version in my project.

However, I have some doubts about it. 1.0-SNAPSHOT looks correct to me, although it doesn't follow semver.

@yegor256 What do you think if we allow such versions?

[yegor256]

@volodya-lombrozo I agree, we should allow x.x-SNAPSHOT (it's Maven convention)

[yegor256]

@h1alexbel can you help please?

[h1alexbel]

@yegor256 yes, I'm in

[yegor256]

@rultor release, tag is 0.0.32

[rultor]

@rultor release, tag is 0.0.32

@yegor256 OK, I will release it now. Please check the progress here.

[rultor]

@rultor release, tag is 0.0.32

@yegor256 Done! FYI, the full log is here (took me 12min).

[h1alexbel]

@volodya-lombrozo should be fixed, try again, please

[volodya-lombrozo]

@h1alexbel Thank you for the fast fix! Works like a charm.