Merge pull request #183 from h1alexbel/179

fix(#179): `Program#defects()` does not declare `IOException`
objectionary · Dec 27, 2024 · b207038 · b207038
2 parents e2e485e + 8dc8a6c
commit b207038
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 3 deletions.
diff --git a/src/main/java/org/eolang/lints/Program.java b/src/main/java/org/eolang/lints/Program.java
@@ -95,7 +95,7 @@ public Program(final XML xml) {
      * Find defects possible defects in the XM§IR file.
      * @return All defects found
      */
-    public Collection<Defect> defects() throws IOException {
+    public Collection<Defect> defects() {
         try {
             final Collection<Defect> messages = new ArrayList<>(0);
             for (final Lint<XML> lint : this.lints) {

diff --git a/src/main/java/org/eolang/lints/Programs.java b/src/main/java/org/eolang/lints/Programs.java
@@ -118,10 +118,21 @@ public Programs(final Map<String, XML> map) {
      * Find defects possible defects in the XMIR file.
      * @return All defects found
      */
-    public Collection<Defect> defects() throws IOException {
+    public Collection<Defect> defects() {
         final Collection<Defect> messages = new LinkedList<>();
         for (final Lint<Map<String, XML>> lint : this.lints) {
-            messages.addAll(lint.defects(this.pkg));
+            try {
+                messages.addAll(lint.defects(this.pkg));
+            } catch (final IOException exception) {
+                throw new IllegalStateException(
+                    String.format(
+                        "Failed to find defects in the '%s' package with '%s' lint",
+                        this.pkg,
+                        lint
+                    ),
+                    exception
+                );
+            }
         }
         return messages;
     }

diff --git a/src/test/java/org/eolang/lints/ProgramTest.java b/src/test/java/org/eolang/lints/ProgramTest.java
@@ -45,6 +45,7 @@
 import org.eolang.parser.TrParsing;
 import org.hamcrest.MatcherAssert;
 import org.hamcrest.Matchers;
+import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.RepeatedTest;
 import org.junit.jupiter.api.Tag;
 import org.junit.jupiter.api.Test;
@@ -192,6 +193,17 @@ void acceptsCanonicalCode() throws IOException {
         );
     }
 
+    @Test
+    void doesNotThrowIoException() {
+        Assertions.assertDoesNotThrow(
+            () ->
+                new Program(
+                    new XMLDocument("<program/>")
+                ).defects(),
+            "Exception was thrown, but it should not be"
+        );
+    }
+
     @Test
     @Tag("benchmark")
     @ExtendWith(MktmpResolver.class)

diff --git a/src/test/java/org/eolang/lints/ProgramsTest.java b/src/test/java/org/eolang/lints/ProgramsTest.java
@@ -31,10 +31,12 @@
 import java.nio.file.Files;
 import java.nio.file.Path;
 import org.cactoos.io.InputOf;
+import org.cactoos.list.ListOf;
 import org.cactoos.set.SetOf;
 import org.eolang.parser.EoSyntax;
 import org.hamcrest.MatcherAssert;
 import org.hamcrest.Matchers;
+import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.RepeatedTest;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
@@ -84,4 +86,12 @@ void checksInParallel(@Mktmp final Path dir) throws IOException {
         );
     }
 
+    @Test
+    void doesNotThrowIoException() {
+        Assertions.assertDoesNotThrow(
+            () -> new Programs(new ListOf<>()).defects(),
+            "Exception was thrown, but it should not be"
+        );
+    }
+
 }