Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example/README: Fix typo in comment #192

Merged
merged 1 commit into from
Feb 19, 2021
Merged

example/README: Fix typo in comment #192

merged 1 commit into from
Feb 19, 2021

Conversation

theimpulson
Copy link
Contributor

The variable is named 'note' and not 'node'. Reflect same in the comment.

Signed-off-by: Aayush Gupta aayushgupta219@gmail.com

The variable is named 'note' and not 'node'. Reflect same in the comment.

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
@theimpulson
Copy link
Contributor Author

@vaind not quite sure why the lint failed when there are no code changes. It says to check the analysis report, where can I find that?

@vaind
Copy link
Contributor

vaind commented Feb 19, 2021

@vaind not quite sure why the lint failed when there are no code changes. It says to check the analysis report, where can I find that?

No issue you've introduced. Sometime pana fails to reach objectbox.io (package homepage) but since this run was executed from a fork, we don't see the full report (there's an issue for that: axel-op/dart-package-analyzer#2)

Thanks for the fix

@vaind vaind merged commit 27dfb13 into objectbox:main Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants