Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NotNeg #169

Closed
ghost opened this issue Mar 16, 2023 · 3 comments
Closed

Remove NotNeg #169

ghost opened this issue Mar 16, 2023 · 3 comments
Labels
enhancement

Comments

@ghost
Copy link

ghost commented Mar 16, 2023

Why there is NotNeg from the first place? We already have IsNeg. NotNeg() is anything shorter than <>IsNeg()?
objeck added a commit that referenced this issue Mar 16, 2023
@objeck
bootstrap for #169 and #170
d73fe1c
@objeck
Copy link
Owner

objeck commented Mar 16, 2023

Ok, no strong opinion on the matter

@ghost
Copy link

ghost commented Mar 16, 2023

Yep. I think NotNeg should be removed because it's redundant. But if I was @objeck, I will choose the easier and most straight forward path that is renaming IsNeg to IsNegative and done. The OP complained about the inconsistency of the API. But I found the API is pretty consistent as the long wordy syntax was used everywhere. Only IsNeg and NotNeg as I found use abbreviated form.

@objeck
Copy link
Owner

objeck commented Mar 23, 2023

Released in 9fc3c7e

@objeck objeck closed this as completed Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@objeck