Reproduce buggy coercion behavior directly inside @optional edge.
#692
+681
−191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obi1kenobi
force-pushed
the
coercion_inside_optional_bug
branch
from
ac6b197 to
f7a8950
Compare
Apparently we had a test case that partly covered this, but it was producing a subtly wrong output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an edge is
@optional, it's allowed to not exist in the data we return. The semantics of type coercion and filtering operations within the@optionalthen become conditional: they apply only if the edge exists for a given row. If the edge didn't exist, all outputs within the@optionalblock arenulland we skip coercions and filters.We were inappropriately applying type coercions to rows where an
@optionaledge didn't exist. This PR reproduces and fixes that problem.