Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve naming, docs, and ergonomics of VertexInfo trait. #267

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Improve naming, docs, and ergonomics of VertexInfo trait. #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions trustfall_core/src/interpreter/hints/dynamic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ use super::CandidateValue;

/// Indicates that a property's value is dependent on another value in the query.
///
/// If [`VertexInfo::dynamically_known_property()`](super::VertexInfo::dynamically_known_property)
/// If [`VertexInfo::dynamically_required_property()`](super::VertexInfo::dynamically_required_property)
/// is able to determine a value for the specified property, it returns
/// a [`DynamicallyResolvedValue`]. The specified property's value may be different
/// in different query results, but the way in which it varies can be determined programmatically
Expand Down Expand Up @@ -131,7 +131,7 @@ use super::CandidateValue;
/// contexts: ContextIterator<'a, Vertex>,
/// resolve_info: &ResolveEdgeInfo,
/// ) -> ContextOutcomeIterator<'a, Vertex, VertexIterator<'a, Vertex>> {
/// if let Some(dynamic_value) = resolve_info.destination().dynamically_known_property("address") {
/// if let Some(dynamic_value) = resolve_info.destination().dynamically_required_property("address") {
/// // The query is looking for a specific recipient's address,
/// // so let's look it up directly.
/// dynamic_value.resolve_with(self, contexts, |vertex, candidate| {
Expand Down
Loading