Allow using *_property helper macros without importing FieldValue
#229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the macro would not compile without `use ...::FieldValue` in the same scope. This uses the special `$crate` metavariable to fix this.
|
Very nice! Perhaps add an integration test to the |
|
Alright, so I decided to import nothing to make it easier to ensure |
obi1kenobi
approved these changes
Mar 31, 2023
| Self::Vertex, | ||
| trustfall::provider::VertexIterator<'static, Self::Vertex>, | ||
| > { | ||
| todo!("schema should not contain neighbors: Berit likes it that way") |
There was a problem hiding this comment.
Extremely specific south Swedish internet sensation 😃
|
Thanks for the fix! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #203
Before, the macro would not compile without
use ...::FieldValuein the same scope. This uses the special$cratemetavariable to fix this.Haven't tested this properly, do we have anywhere nice to put the tests?