Migrate schemaless demo to typescript, use material-ui and Monaco editor #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obi1kenobi
reviewed
May 25, 2022
Comment on lines
+3
to
+9
| import actions_in_repos_with_min_hn_pts from '../../../schemaless/example_queries/actions_in_repos_with_min_hn_pts.graphql'; | ||
| // @ts-ignore | ||
| import crates_io_github_actions from '../../../schemaless/example_queries/crates_io_github_actions.graphql'; | ||
| // @ts-ignore | ||
| import hackernews_patio11_own_post_comments from '../../../schemaless/example_queries/hackernews_patio11_own_post_comments.graphql'; | ||
| // @ts-ignore | ||
| import repos_with_min_hackernews_points from '../../../schemaless/example_queries/repos_with_min_hackernews_points.graphql'; |
There was a problem hiding this comment.
Does this just read the raw string into the import variable?
There was a problem hiding this comment.
Yep. If we want to "do this right", I'd create a separate example queries dir inside this folder! If you look at the webpack config, you'll see that I set it up so that importing graphql files reads as raw strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.