feat: parallelize VisibilityTracker::from_crate #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small perf gains as there isn't much we can parallelize without more code massaging: ``` (92a9868) ❯ cargo criterion --bench indexed_crate --features rayon IndexedCrate/new(aws-sdk-ec2) time: [574.13 ms 575.49 ms 576.92 ms] (changes) ❯ cargo criterion --bench indexed_crate --features rayon IndexedCrate/new(aws-sdk-ec2) time: [557.73 ms 559.38 ms 560.96 ms] change: [-3.1709% -2.8003% -2.4380%] (p = 0.00 < 0.05) Performance has improved. ```
jalil-salame
force-pushed
the
rayon-visibility-tracker
branch
from
5dc3ca8
to
792961f
Compare
obi1kenobi
approved these changes
Aug 29, 2024
obi1kenobi
pushed a commit
that referenced
this pull request
Aug 29, 2024
Small perf gains as there isn't much we can parallelize without more code massaging: ``` (92a9868) ❯ cargo criterion --bench indexed_crate --features rayon IndexedCrate/new(aws-sdk-ec2) time: [574.13 ms 575.49 ms 576.92 ms] (changes) ❯ cargo criterion --bench indexed_crate --features rayon IndexedCrate/new(aws-sdk-ec2) time: [557.73 ms 559.38 ms 560.96 ms] change: [-3.1709% -2.8003% -2.4380%] (p = 0.00 < 0.05) Performance has improved. ```
obi1kenobi
pushed a commit
that referenced
this pull request
Aug 29, 2024
Small perf gains as there isn't much we can parallelize without more code massaging: ``` (92a9868) ❯ cargo criterion --bench indexed_crate --features rayon IndexedCrate/new(aws-sdk-ec2) time: [574.13 ms 575.49 ms 576.92 ms] (changes) ❯ cargo criterion --bench indexed_crate --features rayon IndexedCrate/new(aws-sdk-ec2) time: [557.73 ms 559.38 ms 560.96 ms] change: [-3.1709% -2.8003% -2.4380%] (p = 0.00 < 0.05) Performance has improved. ```
obi1kenobi
pushed a commit
that referenced
this pull request
Aug 29, 2024
Small perf gains as there isn't much we can parallelize without more code massaging: ``` (92a9868) ❯ cargo criterion --bench indexed_crate --features rayon IndexedCrate/new(aws-sdk-ec2) time: [574.13 ms 575.49 ms 576.92 ms] (changes) ❯ cargo criterion --bench indexed_crate --features rayon IndexedCrate/new(aws-sdk-ec2) time: [557.73 ms 559.38 ms 560.96 ms] change: [-3.1709% -2.8003% -2.4380%] (p = 0.00 < 0.05) Performance has improved. ```
obi1kenobi
pushed a commit
that referenced
this pull request
Aug 29, 2024
Small perf gains as there isn't much we can parallelize without more code massaging: ``` (92a9868) ❯ cargo criterion --bench indexed_crate --features rayon IndexedCrate/new(aws-sdk-ec2) time: [574.13 ms 575.49 ms 576.92 ms] (changes) ❯ cargo criterion --bench indexed_crate --features rayon IndexedCrate/new(aws-sdk-ec2) time: [557.73 ms 559.38 ms 560.96 ms] change: [-3.1709% -2.8003% -2.4380%] (p = 0.00 < 0.05) Performance has improved. ```
obi1kenobi
added a commit
that referenced
this pull request
Aug 29, 2024
Small perf gains as there isn't much we can parallelize without more code massaging: ``` (92a9868) ❯ cargo criterion --bench indexed_crate --features rayon IndexedCrate/new(aws-sdk-ec2) time: [574.13 ms 575.49 ms 576.92 ms] (changes) ❯ cargo criterion --bench indexed_crate --features rayon IndexedCrate/new(aws-sdk-ec2) time: [557.73 ms 559.38 ms 560.96 ms] change: [-3.1709% -2.8003% -2.4380%] (p = 0.00 < 0.05) Performance has improved. ``` Co-authored-by: Jalil David Salamé Messina <60845989+jalil-salame@users.noreply.github.com>
obi1kenobi
added a commit
that referenced
this pull request
Aug 29, 2024
Small perf gains as there isn't much we can parallelize without more code massaging: ``` (92a9868) ❯ cargo criterion --bench indexed_crate --features rayon IndexedCrate/new(aws-sdk-ec2) time: [574.13 ms 575.49 ms 576.92 ms] (changes) ❯ cargo criterion --bench indexed_crate --features rayon IndexedCrate/new(aws-sdk-ec2) time: [557.73 ms 559.38 ms 560.96 ms] change: [-3.1709% -2.8003% -2.4380%] (p = 0.00 < 0.05) Performance has improved. ``` Co-authored-by: Jalil David Salamé Messina <60845989+jalil-salame@users.noreply.github.com>
obi1kenobi
added a commit
that referenced
this pull request
Aug 29, 2024
Small perf gains as there isn't much we can parallelize without more code massaging: ``` (92a9868) ❯ cargo criterion --bench indexed_crate --features rayon IndexedCrate/new(aws-sdk-ec2) time: [574.13 ms 575.49 ms 576.92 ms] (changes) ❯ cargo criterion --bench indexed_crate --features rayon IndexedCrate/new(aws-sdk-ec2) time: [557.73 ms 559.38 ms 560.96 ms] change: [-3.1709% -2.8003% -2.4380%] (p = 0.00 < 0.05) Performance has improved. ``` Co-authored-by: Jalil David Salamé Messina <60845989+jalil-salame@users.noreply.github.com>
obi1kenobi
added a commit
that referenced
this pull request
Aug 29, 2024
Small perf gains as there isn't much we can parallelize without more code massaging: ``` (92a9868) ❯ cargo criterion --bench indexed_crate --features rayon IndexedCrate/new(aws-sdk-ec2) time: [574.13 ms 575.49 ms 576.92 ms] (changes) ❯ cargo criterion --bench indexed_crate --features rayon IndexedCrate/new(aws-sdk-ec2) time: [557.73 ms 559.38 ms 560.96 ms] change: [-3.1709% -2.8003% -2.4380%] (p = 0.00 < 0.05) Performance has improved. ``` Co-authored-by: Jalil David Salamé Messina <60845989+jalil-salame@users.noreply.github.com>
4 tasks
|
Resolves #401. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small perf gains as there isn't much we can parallelize without more code massaging:
Last part of #402