Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AssociatedType to schema #211

Merged
merged 12 commits into from
Jul 14, 2023
Merged

Conversation

u9g
Copy link
Contributor

@u9g u9g commented Jul 14, 2023

No description provided.

Copy link
Owner

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of small nits that I think should be resolvable easily. Excited to get this merged soon 🚀

src/adapter/mod.rs Outdated Show resolved Hide resolved
src/adapter/properties.rs Outdated Show resolved Hide resolved
src/rustdoc_schema.graphql Outdated Show resolved Hide resolved
test_crates/traits_with_types/src/lib.rs Outdated Show resolved Hide resolved
test_crates/traits_with_types/Cargo.toml Outdated Show resolved Hide resolved
src/indexed_crate.rs Outdated Show resolved Hide resolved
src/indexed_crate.rs Outdated Show resolved Hide resolved
src/rustdoc_schema.graphql Outdated Show resolved Hide resolved
@obi1kenobi obi1kenobi enabled auto-merge (squash) July 14, 2023 22:09
@obi1kenobi obi1kenobi merged commit 51fedac into obi1kenobi:rustdoc-v26 Jul 14, 2023
7 checks passed
obi1kenobi added a commit that referenced this pull request Jul 14, 2023
* add AssociatedType to schema

* remove from resolveCoercion

* fix copypasta

* implement Item instead of RawType

* rename trait_with_types to traits_with_associated_types

* remove generic test that doesn't test added functionality

* remove last bang on associated_type edge

* Add link to Item rustdoc in graphql type def comment

* Reorder urls from lowest to most important

* put properties together

* Add docs to some of associatedtype

* Fixup docs.

---------

Co-authored-by: Predrag Gruevski <obi1kenobi82@gmail.com>
obi1kenobi added a commit that referenced this pull request Jul 14, 2023
* add AssociatedType to schema

* remove from resolveCoercion

* fix copypasta

* implement Item instead of RawType

* rename trait_with_types to traits_with_associated_types

* remove generic test that doesn't test added functionality

* remove last bang on associated_type edge

* Add link to Item rustdoc in graphql type def comment

* Reorder urls from lowest to most important

* put properties together

* Add docs to some of associatedtype

* Fixup docs.

---------

Co-authored-by: Predrag Gruevski <obi1kenobi82@gmail.com>
obi1kenobi added a commit that referenced this pull request Jul 14, 2023
* add AssociatedType to schema

* remove from resolveCoercion

* fix copypasta

* implement Item instead of RawType

* rename trait_with_types to traits_with_associated_types

* remove generic test that doesn't test added functionality

* remove last bang on associated_type edge

* Add link to Item rustdoc in graphql type def comment

* Reorder urls from lowest to most important

* put properties together

* Add docs to some of associatedtype

* Fixup docs.

---------

Co-authored-by: u9g <git@u9g.dev>
obi1kenobi added a commit that referenced this pull request Jul 14, 2023
* add AssociatedType to schema

* remove from resolveCoercion

* fix copypasta

* implement Item instead of RawType

* rename trait_with_types to traits_with_associated_types

* remove generic test that doesn't test added functionality

* remove last bang on associated_type edge

* Add link to Item rustdoc in graphql type def comment

* Reorder urls from lowest to most important

* put properties together

* Add docs to some of associatedtype

* Fixup docs.

---------

Co-authored-by: u9g <git@u9g.dev>
@u9g u9g deleted the associated-type branch July 14, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants