Filter total # of checks and filenames in snapshots

[suaviloquence]

Filters, for reproducibility:

• total number of checks run
• number of passed checks
• filenames in spans (not sure about the regex on this one, let me know what you think)

[obi1kenobi]

I'm not sure about this filter 🤔 Could you walk me through it?

Right now it seems like it'll redact the name, but will leave:

• the line number
• the name of the type or function
• the number of instances of that lint

[suaviloquence]

Yes, my intention is to just redact the path of the file, as e.g., this was different in CI and locally for me. With the same input, the line number, type name, etc. will all be deterministic and will be the same regardless of the execution environment, right? When that's the case, I think it makes sense to keep them in the snapshot.

[obi1kenobi]

Ah, I see. In that case, let's redact just the changed prefix. Here's one way to do it:

let this_file = std::path::Path::new(file!()).canonicalize().expect("canonicalization failed"); will give us a canonical file path for the file where that line runs. We can then use .parent() calls to get to the repo root. Let's call this functionality get_root_path().

We can then use regex::escape(&get_root_path()).as_str() to define a regex matcher and replace the root path with [ROOT] or something similarly obvious.

I haven't looked that closely into insta, so maybe there's an even better way. In the worst case, I think the above should work okay.

[obi1kenobi]

Excellent, ship it 🚀