Add size limit for storing in the DB #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelemin
force-pushed
the
db_size_limit
branch
from
98d310b to
bce21f6
Compare
michelemin
force-pushed
the
db_size_limit
branch
from
1b43d0f to
47a1633
Compare
michelemin
force-pushed
the
db_size_limit
branch
from
47a1633 to
f46c09f
Compare
obelisk
requested changes
Jan 21, 2025
runtime/plaid/src/executor/mod.rs
Outdated
| @@ -104,6 +104,10 @@ pub struct Env { | |||
| pub api: Arc<Api>, | |||
| // A handle to the storage system if one is configured | |||
| pub storage: Option<Arc<Storage>>, | |||
| // Number of bytes the module is currently saving in persistent storage | |||
| pub storage_current: Arc<RwLock<u64>>, | |||
There was a problem hiding this comment.
Mutex might be faster here. The critical section for these kinds of checks are going to be super short. RWLock isn't a problem but worth looking into.
| // Note: we _substract_ the size of existing data. If we were to insert the new data, the old data would be overwritten. | ||
| let used_storage = match env_data.storage_current.read() { | ||
| Ok(data) => *data, | ||
| Err(_) => panic!(), |
There was a problem hiding this comment.
We should never panic. This needs to be surfaced and handled in some way.
michelemin
force-pushed
the
db_size_limit
branch
from
9ad02f3 to
3114c37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional size limit that modules must respect when storing data in the permanent storage (e.g., DB).
If a module tries to store more than it is allowed, the insertion will fail.
Modules can also be given (by default or through overrides)
Unlimitedstorage in the DB, in which case we will still count how many bytes they are storing, but we will not fail the insert.When counting what is stored, we take into account the byte length of the key and the values.
Breaking changes
The configuration needs a new section that looks like