-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework JSON Serialization section #414
Conversation
payload, and the signature of the JWS JSON serialized SD-JWT using a `.` | ||
character as a separator, and using the Disclosures from the `disclosures` | ||
member of the unprotected header. In case of multiple signatures, only the first | ||
one is used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My first read of this last sentence had me thinking it was only about using the first signature value for constructing the "Issuer-signed JWT" part for input to the sd_hash
.
But I think it's also trying to say that, in the case of multiple signatures in the general serialization, the disclosures
can only show up (and be used for constructing the sd_hash
input) in the header
of first of the signatures
array. And that the kb_jwt
has to be there too.
And now I see that is what is said in the General JSON Serialization subsection below. Sorry!
But a bit more clarity here might still be good? I don't know that this is that much better but maybe:
one is used. | |
one is used for the Disclosures and Key Binding JWT. |
Side note: using only the first one feels kinda icky TBH and the general issue was one reason I'd tried to avoid using the unprotected header for the SD-JWT pieces. But it seems a pragmatic way to do this given all the factors and constraints involved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think the clarification is useful! If we can come up with a better way than just using the first disclosure, I would be open to that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, with the General JSON Serialization and wanting to use the unprotected headers for JAdES, I think that going with the first signature element is probably the most reasonable thing to do.
This one needs a doc history entry under -09 :) |
Co-authored-by: Brian Campbell <71398439+bc-pi@users.noreply.github.com>
Added! |
This addresses Issue #403 and #392
Uses this new branch in sd-jwt-python.
Rendered version: https://drafts.oauth.net/oauth-selective-disclosure-jwt/danielfett/new-json-serialization/draft-ietf-oauth-selective-disclosure-jwt.html