Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tempo to decimal point #12

Merged
merged 4 commits into from
Jun 27, 2023
Merged

Allow tempo to decimal point #12

merged 4 commits into from
Jun 27, 2023

Conversation

rokujyushi
Copy link
Contributor

OpenUtauプロジェクトのIssueで、テンポが小数点まで入力されている場合、ラベル作成時にタイミングがずれる問題(stakira/OpenUtau#431 )が出ていたので、丸め込まないように変更した。

Issue in the OpenUtau project (stakira/OpenUtau#431 ) where the timing was off when creating labels if tempo was entered to the decimal point, so it was changed to not rounding.

Copy link
Owner

@oatsu-gh oatsu-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。ただ、floatのかわりにDecimalに変換してほしいです。タイミング計算をするときに、末尾で丸め誤差が出てしまう場合があるためです。

@rokujyushi rokujyushi requested a review from oatsu-gh June 22, 2023 08:51
@oatsu-gh
Copy link
Owner

Thank you!

@oatsu-gh oatsu-gh merged commit 6d2c62b into oatsu-gh:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants