Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: links to emerald and cipher #466

Merged
merged 1 commit into from
Dec 23, 2024
Merged

fix: links to emerald and cipher #466

merged 1 commit into from
Dec 23, 2024

Conversation

rube-de
Copy link
Contributor

@rube-de rube-de commented Dec 4, 2024 •
edited by matevz
Loading

fixes the links which get broken through 1041

Merge after #466

@netlify Netlify
Copy link

netlify bot commented Dec 4, 2024 •
edited
Loading

❌ Deploy Preview for oasisprotocol-sapphire-paratime failed.

Name Link
🔨 Latest commit 6c67627
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-sapphire-paratime/deploys/676962c955c09a0008b2a821

@rube-de rube-de force-pushed the rube/fix-doc-links-paratimes branch from 48408df to 50e60a1 Compare December 4, 2024 14:50
@rube-de rube-de marked this pull request as ready for review December 4, 2024 15:07
@rube-de rube-de requested review from aefhm and matevz and removed request for aefhm December 4, 2024 15:07
@rube-de rube-de mentioned this pull request Dec 4, 2024
Merged
matevz
matevz approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove explicit mentioning of Emerald and Cipher.

docs/README.mdx Outdated Show resolved Hide resolved
docs/guide.mdx Outdated Show resolved Hide resolved
docs/README.mdx Outdated Show resolved Hide resolved
aefhm
aefhm approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@aefhm aefhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a bit of circularness, so the preview just won't work in this situation, but I think that is okay. Merging and publishing (from docs repo) will happen pretty quickly.

@rube-de rube-de force-pushed the rube/fix-doc-links-paratimes branch from 50e60a1 to 707f695 Compare December 23, 2024 13:16
@rube-de rube-de force-pushed the rube/fix-doc-links-paratimes branch from 707f695 to 6c67627 Compare December 23, 2024 13:16
@rube-de rube-de merged commit 6acf367 into main Dec 23, 2024
10 of 12 checks passed
@rube-de rube-de deleted the rube/fix-doc-links-paratimes branch December 23, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aefhm aefhm aefhm approved these changes

@matevz matevz matevz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rube-de @matevz @aefhm