packaging: remove semver tags from package versions #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-sapphire-paratime canceled.
|
|
So quick point of thought, currently If I do So, I think we should keep sapphire-hardhat semver tag as |
matevz
approved these changes
Sep 10, 2024
CedarMist
force-pushed
the
CedarMist/package-versioning-v2
branch
from
96c1479 to
2242de7
Compare
Isn't this the desired behavior? 🤔
Just checking, you are suggesting we keep it on |
CedarMist
force-pushed
the
CedarMist/package-versioning-v2
branch
from
2242de7 to
b938516
Compare
|
Release checklist:
Have skipped these as unnecessary
|
github-actions bot
added a commit
that referenced
this pull request
Sep 16, 2024
…edarMist/package-versioning-v2 packaging: remove semver tags from package versions f33604e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, need to re-release packages to get versioning working correctly.
So, we're going to archive:
@oasisprotocol/sapphire-paratimev2.0.0-alpha.0 on thelatesttag@oasisprotocol/sapphire-paratimev2.0.0-next.3 on thenexttagThen release
@oasisprotocol/sapphire-paratimev2.0.0 on thenexttagThe
sapphire-viem-v2,sapphire-ethers-v6,sapphire-hardhatandsapphire-wagmi-v2packages will be published on their ownlatesttags.Meaning people who
npm install @oasisprotocol/sapphire-paratimewill get v1.x by default, but if you install@oasisprotocol/sapphire-ethers-v6you'll get@oasisprotocol/sapphire-paratimev2 as a dependency.This means we'll be tagging
clients/js/v2.0.0-next(to publish to thenextdist-tag on NPMJS), butintegrations/ethers-v6/v6.0.0(to publish tolatest).Version resolution for dependencies on package.json will ignore the dist-tags, but adhere to any semver rules.