Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix packaging releases, use pnpm rather than npm #362

Closed
CedarMist opened this issue Aug 26, 2024 · 0 comments · Fixed by #363
Closed

Fix packaging releases, use pnpm rather than npm #362

CedarMist opened this issue Aug 26, 2024 · 0 comments · Fixed by #363
Assignees
@CedarMist
Labels
javascript Pull requests that update JavaScript code packaging

Comments

@CedarMist
Copy link
Member

The following packages aren't released properly:

Their dependencies in package.json show workspace:^ because they're released with NPM rather than PNPM.

In https://github.com/oasisprotocol/sapphire-paratime/blob/main/.github/workflows/publish.yaml it should use pnpm to publish the packages.

We should also enable provenance when publishing packages.
@CedarMist CedarMist added javascript Pull requests that update JavaScript code packaging labels Aug 26, 2024
@CedarMist CedarMist mentioned this issue Aug 26, 2024
Merged
@CedarMist CedarMist self-assigned this Aug 27, 2024
CedarMist added a commit that referenced this issue Aug 27, 2024
@CedarMist
packaging: bump versions + add CHANGELOG entries
87abf31 
re: #362
re: #363

for the following packages:

 * oasisprotocol/sapphire-paratime
 * oasisprotocol/sapphire-ethers-v6
 * oasisprotocol/sapphire-hardhat
 * oasisprotocol/sapphire-viem-v2
 * oasisprotocol/sapphire-wagmi-v2

They will be released under the `next` tag, to test updated publish.yaml workflow
@CedarMist CedarMist mentioned this issue Aug 27, 2024
Merged
CedarMist added a commit that referenced this issue Aug 27, 2024
@CedarMist
packaging: bump versions + add CHANGELOG entries
7e65ac6 
re: #362
re: #363

for the following packages:

 * oasisprotocol/sapphire-paratime
 * oasisprotocol/sapphire-ethers-v6
 * oasisprotocol/sapphire-hardhat
 * oasisprotocol/sapphire-viem-v2
 * oasisprotocol/sapphire-wagmi-v2

They will be released under the `next` tag, to test updated publish.yaml workflow
after publishing the bundlephobia links in the main README.md should work
It should also be possible to install the packages & resolve their dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CedarMist CedarMist

Labels
javascript Pull requests that update JavaScript code packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

packaging: use PNPM for publishing, with correct tags oasisprotocol/sapphire-paratime
1 participant
@CedarMist