go/governance: Add support for proposal metadata #5650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
kostko
force-pushed
the
kostko/feature/gov-proposal-names
branch
from
863740e to
7560aa3
Compare
kostko
requested review from
peterjgilbert,
pro-wh,
ptrus and
peternose
as code owners
kostko
force-pushed
the
kostko/feature/gov-proposal-names
branch
2 times, most recently
from
6a2ef0d to
5976573
Compare
peternose
approved these changes
Apr 22, 2024
| for i := 0; i < values.NumField(); i++ { | ||
| if !values.Field(i).IsNil() { | ||
| numProposals++ | ||
| func (p *ProposalContent) ValidateBasic(params *ConsensusParameters) error { |
There was a problem hiding this comment.
Suggested change
| func (p *ProposalContent) ValidateBasic(params *ConsensusParameters) error { | |
| func (p *ProposalContent) ValidateBasic(allowMetadata bool) error { |
Easier to test.
kostko
force-pushed
the
kostko/feature/gov-proposal-names
branch
from
5976573 to
5e7b3ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.