Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

governance: fix delegator-validator vote match check #5479

Merged
merged 2 commits into from
Nov 28, 2023
Merged

governance: fix delegator-validator vote match check #5479

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ca10a8
governance: fix delegator-validator vote match check
ptrus Nov 27, 2023
d77922c
tests/e2e/genesis: update mainnet genesis dump artifact url
ptrus Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/5479.bugfix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
governance: fix delegator-validator vote match check
5 changes: 3 additions & 2 deletions go/consensus/cometbft/apps/governance/governance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,8 +416,9 @@ func (app *governanceApplication) closeProposal(
}
delegationToValidator = true
validatorVote := validatorVotes[to]
if validatorVote == &vote.Vote { //nolint:gosec
// Vote matches the delegated validator vote.

// Skip if vote matches the delegated validator vote.
if validatorVote != nil && *validatorVote == vote.Vote {
continue
}

Expand Down
Loading