go/oasis-test-runner: Fix flaky key manager rotation failure test #5455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
kostko
approved these changes
Nov 17, 2023
peternose
force-pushed
the
peternose/trivial/fix-km-rotation-failure-test
branch
2 times, most recently
from
1fc39ff to
5d4ef9d
Compare
In the key manager rotation failure test, start key managers after they deregister to ensure that both are added to the committee simultaneously. If key managers are started randomly, there is a risk that only one will be added to the committee, as the other may register in another epoch.
peternose
force-pushed
the
peternose/trivial/fix-km-rotation-failure-test
branch
from
5d4ef9d to
725c84a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5455 +/- ##
==========================================
+ Coverage 66.37% 66.51% +0.13%
==========================================
Files 533 533
Lines 56390 56390
==========================================
+ Hits 37427 37505 +78
+ Misses 14538 14484 -54
+ Partials 4425 4401 -24 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the key manager rotation failure test, start key managers after they deregister to ensure that both are added to the committee simultaneously. If key managers are started randomly, there is a risk that only one will be added to the committee, as the other may register in another epoch.