simplify

check-breaking/action.yml

@@ -8,18 +8,13 @@ inputs:
     description: "Path of revised OpenAPI spec in YAML or JSON format"
     required: true
   fail-on-diff:
-    description: "Fail with exit code 1 if any ERR-level breaking changes are found"
+    description: "Fail with exit code 1 if any breaking changes are found"
     required: false
-    default: true
-  fail-on-warns:
-    description: "Fail with exit code 1 if any WARN-level breaking changes are found"
-    required: false
-    default: 'false'
+    default: 'true'
 runs:
   using: "docker"
   image: "Dockerfile"
   args:
     - ${{ inputs.base }}
     - ${{ inputs.revision }}
     - ${{ inputs.fail-on-diff }}
-    - ${{ inputs.fail-on-warns }}

check-breaking/entrypoint.sh

@@ -3,13 +3,13 @@
 readonly base="$1"
 readonly revision="$2"
 readonly fail_on_diff="$3"
-readonly fail_on_warns="$4"
 
-echo "running oasdiff check for breaking-changes... base: $base, revision: $revision, fail_on_diff: $fail_on_diff, fail_on_warns: $fail_on_warns"
+echo "running oasdiff check for breaking-changes... base: $base, revision: $revision, fail_on_diff: $fail_on_diff"
 
-readonly fail_on_argument=$(if [ "$fail_on_warns" = "true" ]; then echo "--fail-on WARN"; fi)
+set -o pipefail
 
-oasdiff breaking "$base" "$revision" "$fail_on_argument"
-if [ $? != 0 ] && [ "$fail_on_diff" = "true"  ]; then
-  exit 1
+if [[ $fail_on_diff = "true" ]]; then
+  oasdiff breaking "$base" "$revision" --fail-on WARN
+else
+  oasdiff breaking "$base" "$revision"
 fi

diff/entrypoint.sh

@@ -8,9 +8,10 @@ readonly fail_on_diff="$4"
 
 echo "running oasdiff... base: $base, revision: $revision, format: $format, fail_on_diff: $fail_on_diff"
 
-if [ "$fail_on_diff" = "true"  ]
-then
+set -o pipefail
+
+if [[ $fail_on_diff" == "true" ]]; then
   oasdiff diff "$base" "$revision" --fail-on-diff --format "$format" 
 else
-  oasdiff diff "$base" "$revision" --format "$format" 
+  oasdiff diff "$base" "$revision" --format "$format"
 fi