Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

modifying ci_scripts/install_pmem_common.sh oap-ape/README.md #213

Open
wants to merge 3 commits into
base: ape
Choose a base branch
from

Conversation

yspMing
Copy link

@yspMing yspMing commented Nov 18, 2021

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?
https://github.com/oap-project/sql-ds-cache/issues

Then could you also rename pull request title and commit log in the following format?

[SQL-DS-CACHE-${ISSUES_ID}] ${detailed message}

See also:

@jikunshang
Copy link
Collaborator

please change your target branch to ape

@jikunshang jikunshang changed the base branch from master to ape November 18, 2021 15:03
@@ -72,7 +72,7 @@ mvn clean install
Native and Java build. We will use `$OAP_ROOT_DIR/oap-ape/ape-java/ape-spark/target/ape-spark-1.1.0-SNAPSHOT.jar`, `$OAP_ROOT_DIR/oap-ape/ape-java/ape-flink/ape-flink-x.xx.x/target/ape-flink-x.xx.x-1.1.0-SNAPSHOT.jar` later.
```
cd $OAP_ROOT_DIR/oap-ape/ape-java
mvn clean package -am -Pshading
mvn clean package -am --batch-mode -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not change -Pshading, any comments @ZJie1

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we should not change it. This is for the packing native to the ape spark jar and ape-server also use this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I cannot compile successfully if I use the -Pshading command.
Here is the error

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.2.4:shade (default) on project ape-server: Error creating shaded jar: Could not resolve following dependencies: [com.intel.oap:ape-flink-common:jar:1.1.0-SNAPSHOT (compile), com.intel.oap:ape-client:jar:1.1.0-SNAPSHOT (compile), com.intel.oap:ape-hcfs:jar:1.1.0-SNAPSHOT (compile)]: Could not resolve dependencies for project com.intel.oap:ape-flink-1.13.2:jar:1.1.0-SNAPSHOT: The following artifacts could not be resolved: com.intel.oap:ape-flink-common:jar:1.1.0-SNAPSHOT, com.intel.oap:ape-client:jar:1.1.0-SNAPSHOT, com.intel.oap:ape-hcfs:jar:1.1.0-SNAPSHOT: Could not find artifact com.intel.oap:ape-flink-common:jar:1.1.0-SNAPSHOT -> [Help 1]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants