Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML-41] Revert to old oneCCL and Prepare for OAP 1.1 #40

Merged
merged 15 commits into from
Mar 23, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/oap-mllib-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,4 @@ jobs:
source /opt/intel/oneapi/dal/latest/env/vars.sh
source /opt/intel/oneapi/tbb/latest/env/vars.sh
source /tmp/oneCCL/build/_install/env/setvars.sh
# temp disable and will enable for new release of oneCCL
#./build.sh
./test.sh
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
*.o
*.log
.vscode
*.iml
target/
.idea/
.idea_modules/
19 changes: 7 additions & 12 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ You can find the all the OAP MLlib documents on the [project web page](https://o

### Java/Scala Users Preferred

Use a pre-built OAP MLlib JAR to get started. You can firstly download OAP package from [OAP-JARs-Tarball](https://github.com/Intel-bigdata/OAP/releases/download/v1.0.0-spark-3.0.0/oap-1.0.0-bin-spark-3.0.0.tar.gz) and extract this Tarball to get `oap-mllib-x.x.x-with-spark-x.x.x.jar` under `oap-1.0.0-bin-spark-3.0.0/jars`.
Use a pre-built OAP MLlib JAR to get started. You can firstly download OAP package from [OAP-JARs-Tarball](https://github.com/oap-mllib/releases/download/v1.1.0-spark-3.0.0/oap-1.1.0-bin-spark-3.0.0.tar.gz) and extract this Tarball to get `oap-mllib-x.x.x-with-spark-x.x.x.jar` under `oap-1.1.0-bin-spark-3.0.0/jars`.

Then you can refer to the following [Running](#running) section to try out.

Expand Down Expand Up @@ -65,14 +65,6 @@ To use K-means example for sanity check, you need to upload a data file to your
$ ./run.sh
```

### Benchmark with HiBench
Use [Hibench](https://github.com/Intel-bigdata/HiBench) to generate dataset with various profiles, and change related variables in `run-XXX.sh` script when applicable. Then run the following commands:
```
$ cd oap-mllib/examples/kmeans-hibench
$ ./build.sh
$ ./run-hibench-oap-mllib.sh
```

### PySpark Support

As PySpark-based applications call their Scala couterparts, they shall be supported out-of-box. An example can be found in the [Examples](#examples) section.
Expand All @@ -95,7 +87,7 @@ Intel® oneAPI Toolkits and its components can be downloaded and install from [h

More details about oneAPI can be found [here](https://software.intel.com/content/www/us/en/develop/tools/oneapi.html).

You can also refer to [this script and comments in it](https://github.com/Intel-bigdata/OAP/blob/branch-1.0-spark-3.x/oap-mllib/dev/install-build-deps-centos.sh) to install correct oneAPI version and manually setup the environments.
You can also refer to [this script and comments in it](https://github.com/oap-project/oap-mllib/blob/branch-1.1-spark-3.x/dev/install-build-deps-centos.sh) to install correct oneAPI version and manually setup the environments.

Scala and Java dependency descriptions are already included in Maven POM file.

Expand Down Expand Up @@ -138,7 +130,7 @@ CCL_ROOT | Path to oneCCL home directory
We suggest you to source `setvars.sh` script into current shell to setup building environments as following:

```
$ source /opt/intel/inteloneapi/setvars.sh
$ source /opt/intel/oneapi/setvars.sh
$ source /your/oneCCL_source_code/build/_install/env/setvars.sh
```

Expand All @@ -160,8 +152,11 @@ Example | Description
----------------|---------------------------
kmeans | K-means example for Scala
kmeans-pyspark | K-means example for PySpark
kmeans-hibench | Use HiBench-generated input dataset to benchmark K-means performance
pca | PCA example for Scala
pca-pyspark | PCA example for PySpark

## List of Accelerated Algorithms

* K-Means (CPU, Experimental)
* PCA (CPU, Experimental)

2 changes: 1 addition & 1 deletion dev/install-build-deps-centos.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ cd /tmp
rm -rf oneCCL
git clone https://github.com/oneapi-src/oneCCL
cd oneCCL
git checkout 2021.1
git checkout beta08
mkdir -p build && cd build
cmake ..
make -j 2 install
Expand Down
2 changes: 1 addition & 1 deletion dev/install-build-deps-ubuntu.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ echo "Building oneCCL ..."
cd /tmp
git clone https://github.com/oneapi-src/oneCCL
cd oneCCL
git checkout 2021.1
git checkout beta08
mkdir build && cd build
cmake ..
make -j 2 install
Expand Down
6 changes: 0 additions & 6 deletions dev/test-cluster/config-ssh.sh

This file was deleted.

24 changes: 0 additions & 24 deletions dev/test-cluster/core-site.xml

This file was deleted.

22 changes: 0 additions & 22 deletions dev/test-cluster/envs.sh

This file was deleted.

99 changes: 0 additions & 99 deletions dev/test-cluster/hadoop-env.sh

This file was deleted.

32 changes: 0 additions & 32 deletions dev/test-cluster/hdfs-site.xml

This file was deleted.

42 changes: 0 additions & 42 deletions dev/test-cluster/setup-cluster.sh

This file was deleted.

12 changes: 0 additions & 12 deletions dev/test-cluster/setup-python3-env.sh

This file was deleted.

34 changes: 0 additions & 34 deletions dev/test-cluster/spark-defaults.conf

This file was deleted.

Loading