This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-947] Add a whole stage fallback strategy #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHILO-HE
force-pushed
the
fallback-strategy
branch
2 times, most recently
from
15c04f6
to
e75e7d4
Compare
This reverts commit c4210ccfe39fac9b144117ec403bd9b00d8b5703.
…urce BatchScanExec
PHILO-HE
force-pushed
the
fallback-strategy
branch
from
e75e7d4
to
0da5459
Compare
PHILO-HE
commented
Jul 18, 2022
| } | ||
| isLeafPlanExchange || (SQLConf.get.adaptiveExecutionEnabled && (sanityCheck(plan) && | ||
| !plan.logicalLink.exists(_.isStreaming) && | ||
| !plan.expressions.exists(_.find(_.isInstanceOf[DynamicPruningSubquery]).isDefined) && |
There was a problem hiding this comment.
This part of code is ported from spark's source code. From spark 3.2, DPP can be coexisted with AQE, so the below statement should be removed for spark 3.2. We differentiated the implementation in shim layers.
!plan.expressions.exists(_.find(_.isInstanceOf[DynamicPruningSubquery]).isDefined
PHILO-HE
commented
Jul 18, 2022
| def supportAdaptive(plan: SparkPlan): Boolean | ||
|
|
||
| def supportAdaptiveWithExchangeConsidered(plan: SparkPlan): Boolean = { | ||
| isLeafPlanExchange(plan) || supportAdaptive(plan) |
There was a problem hiding this comment.
It looks isLeafPlanExchange should not be checked recursively. So we moved it from #supportAdaptive.
Such handling can fix issues for tpc-ds q23b in spark 3.1, where the code wrongly judges that AQE is supported.
PHILO-HE
commented
Jul 18, 2022
| /** | ||
| * Ported from InsertAdaptiveSparkPlan. | ||
| */ | ||
| override def supportAdaptive(plan: SparkPlan): Boolean = { |
There was a problem hiding this comment.
Consistent with spark 3.1 source code.
PHILO-HE
commented
Jul 18, 2022
| /** | ||
| * Ported from InsertAdaptiveSparkPlan. | ||
| */ | ||
| override def supportAdaptive(plan: SparkPlan): Boolean = { |
There was a problem hiding this comment.
Consistent with spark 3.2 source code.
PHILO-HE
force-pushed
the
fallback-strategy
branch
from
2e9998a
to
9de4841
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Let whole stage fallback if there would be 3 or more fallbacks in a stage.
How was this patch tested?
UT.