Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-463] version bump to 1.3.0-SNAPSHOT #488

Merged
merged 2 commits into from
Dec 20, 2021

Conversation

zhouyuan
Copy link
Collaborator

What changes were proposed in this pull request?

version bump to 1.3.0-snapshot
Signed-off-by: Yuan Zhou yuan.zhou@intel.com

How was this patch tested?

N/A

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
@github-actions
Copy link

#463

@zhztheplayer
Copy link
Collaborator

I am not sure but does maven recognize the lowercase snapshot as a valid suffix for snapshot artifacts?

@zhztheplayer
Copy link
Collaborator

zhztheplayer commented Aug 24, 2021

Found no official documents yet but there were some discussions related to this in other communities https://developer.jboss.org/thread/89886

@zhouyuan
Copy link
Collaborator Author

@weiting-chen should we use uppercase SNAPSHOT here?

@weiting-chen
Copy link
Collaborator

@weiting-chen should we use uppercase SNAPSHOT here?

Yes, I would suggest using "SNAPSHOT" instead of lowercase, it's a typical way to use in most common projects.

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
@zhouyuan zhouyuan changed the title [NSE-463] version bump to 1.3.0-snapshot [NSE-463] version bump to 1.3.0-SNAPSHOT Sep 26, 2021
@zhouyuan zhouyuan merged commit 58e6d33 into oap-project:master Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants