This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-433]Support pre-built Jemalloc #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouyuan
reviewed
Aug 4, 2021
| @@ -8,6 +8,7 @@ STATIC_ARROW=${3:-OFF} | |||
| BUILD_PROTOBUF=${4:-ON} | |||
| ARROW_ROOT=${5:-/usr/local} | |||
| ARROW_BFS_INSTALL_DIR=${6} | |||
| BUILD_JEMALLOC=${7:-ON} | |||
There was a problem hiding this comment.
should also define the option here?
https://github.com/oap-project/gazelle_plugin/blob/master/native-sql-engine/cpp/src/CMakeLists.txt#L22-L28
There was a problem hiding this comment.
Yes, you are right, I miss the default setting for BUILD_JEMALLOC.
Done to send a new commit to fix it.
zhouyuan
approved these changes
Aug 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To support build Jemalloc v5.2.1 from source
How was this patch tested?
Has passed the testing in the local server.