Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-186] backport to 1.1 branch #268

Merged
merged 2 commits into from
Apr 23, 2021

Commits on Apr 21, 2021

  1. [NSE-262] fix remainer loss in decimal divide (oap-project#263)

    * fix decimal divide int issue
    
    * correct cpp uts
    
    * use const reference
    
    Co-authored-by: Yuan <yuan.zhou@outlook.com>
    
    Co-authored-by: Yuan <yuan.zhou@outlook.com>
    rui-mo and zhouyuan committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    6c2ea2f View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. [NSE-265] Reserve enough memory before UnsafeAppend in builder (oap-p…

    …roject#266)
    
    * change the UnsafeAppend to Append
    
    * fix buffer builder in shuffle
    
    shuffle builder use UnsafeAppend API for better performance. it
    tries to reserve enough space based on results of last recordbatch,
    this maybe not buggy if there's a dense recordbatch after a sparse one.
    
    this patch adds below fixes:
    - adds Reset() after Finish() in builder
    - reserve length for offset_builder in binary builder
    
    A further clean up on the reservation logic should be needed.
    
    Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
    
    Co-authored-by: Yuan Zhou <yuan.zhou@intel.com>
    JkSelf and zhouyuan committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    214c38b View commit details
    Browse the repository at this point in the history