Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-23]fix columnar SMJ fallback #24

Merged
merged 2 commits into from
Jan 11, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -301,16 +301,32 @@ case class ColumnarSortMergeJoinExec(
}
ColumnarCodegenContext(inputSchema, outputSchema, codeGenNode)
}
val triggerBuildSignature = getCodeGenSignature
//do not call prebuild so we could skip the c++ codegen
//val triggerBuildSignature = getCodeGenSignature

try {
ColumnarSortMergeJoin.precheck(
leftKeys,
rightKeys,
resultSchema,
joinType,
condition,
left,
right,
joinTime,
prepareTime,
totaltime_sortmegejoin,
numOutputRows,
sparkConf)
} catch {
case e: Throwable =>
throw e
}


/***********************************************************/
def getCodeGenSignature: String =
if (resultSchema.size > 0 && !leftKeys
.filter(expr => bindReference(expr, left.output, true).isInstanceOf[BoundReference])
.isEmpty && !rightKeys
.filter(expr => bindReference(expr, right.output, true).isInstanceOf[BoundReference])
.isEmpty) {
if (resultSchema.size > 0) {
try {
ColumnarSortMergeJoin.prebuild(
leftKeys,
Expand Down