This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-183] add Timestamp in native side #184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
|
rui-mo
changed the title
|
@xuechendi @JkSelf hi, I add timestamp in this pr, could you help take a review? |
|
|
zhouyuan
reviewed
Mar 25, 2021
| @@ -428,6 +432,91 @@ class ArrayAppender<DataType, enable_if_decimal<DataType>> : public AppenderBase | |||
| bool has_null_ = false; | |||
| }; | |||
|
|
|||
| template <typename DataType> | |||
| class ArrayAppender<DataType, enable_if_timestamp<DataType>> : public AppenderBase { | |||
There was a problem hiding this comment.
it looks like we could merge this with number, date, decimal?
rui-mo
commented
Mar 25, 2021
| ArrayAppender(arrow::compute::ExecContext* ctx, AppenderType type = left) | ||
| : ctx_(ctx), type_(type) { | ||
| std::unique_ptr<arrow::ArrayBuilder> array_builder; | ||
| arrow::MakeBuilder(ctx_->memory_pool(), arrow::int64(), &array_builder); |
There was a problem hiding this comment.
@zhouyuan this is because TimestampType does not contain "arrow::TypeTraits::type_singleton()", so it is separated out.
zhouyuan
reviewed
Mar 25, 2021
native-sql-engine/cpp/src/codegen/arrow_compute/ext/array_appender.h
Outdated
Show resolved
Hide resolved
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr adds Timestamp in native side.
fixed: #183
How was this patch tested?
needs test