This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-153] Fix incorrect quries after enabled Decimal #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chendi Xue <chendi.xue@intel.com>
Signed-off-by: Chendi Xue <chendi.xue@intel.com>
…data Signed-off-by: Chendi Xue <chendi.xue@intel.com>
Signed-off-by: Chendi Xue <chendi.xue@intel.com>
|
@rui-mo , I submitted this FIX, let's have a check |
Signed-off-by: Chendi Xue <chendi.xue@intel.com>
Signed-off-by: Chendi Xue <chendi.xue@intel.com>
…data Signed-off-by: Chendi Xue <chendi.xue@intel.com>
Signed-off-by: Chendi Xue <chendi.xue@intel.com>
|
|
zhouyuan
reviewed
Mar 11, 2021
| @@ -889,7 +889,7 @@ static inline bool append(unsafeHashMap* hashMap, CType keyRow, int hashVal, cha | |||
| char* base = hashMap->bytesMap; | |||
| int klen = 0; | |||
| const int vlen = value_size; | |||
| const int recordLength = 4 + +klen + vlen + 4; | |||
There was a problem hiding this comment.
odd, this seems didn't introduce any compile issue?
support NaN comparison in wscg
|
|
Signed-off-by: Chendi Xue <chendi.xue@intel.com>
|
ce59227 fixed Q54 |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, q32, q32, q39a, q54 should be fixed.
Q65 and Q69 may need to verify on partition dataset