Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-1108] allow to use different cases in column names #1098

Merged
merged 5 commits into from
Sep 14, 2022

Conversation

zhouyuan
Copy link
Collaborator

@zhouyuan zhouyuan commented Sep 5, 2022

What changes were proposed in this pull request?

This patch fixes the different cases in column names by converting them to lower case

How was this patch tested?

pass jenkins

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
@github-actions
Copy link

github-actions bot commented Sep 5, 2022

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/native-sql-engine/issues

Then could you also rename commit message and pull request title in the following format?

[NSE-${ISSUES_ID}] ${detailed message}

See also:

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
This reverts commit 32dfc62.
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
@zhouyuan zhouyuan changed the title allow to use differnent case in SQL [NSE-1108] allow to use different cases in column names Sep 14, 2022
@github-actions
Copy link

#1108

@zhouyuan zhouyuan marked this pull request as ready for review September 14, 2022 09:51
@zhouyuan
Copy link
Collaborator Author

note: this fix relies on lower case table schema, a better solution would be switching to the boundreference:
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala#L69

@zhouyuan zhouyuan merged commit f834def into oap-project:main Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant