This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-1019] [NSE-1020] Support more date formats and be aware of local time zone in handling unix timestamp #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch depends on oap-project/arrow#124. We need to revert the change for arrow branch at last. |
PHILO-HE
commented
Jul 13, 2022
| Row(java.lang.Long.valueOf(1249084800L)))) | ||
| Seq(Row(java.lang.Long.valueOf(1248940800L)), | ||
| Row(java.lang.Long.valueOf(1249027200L)), | ||
| Row(java.lang.Long.valueOf(1249113600L)))) |
There was a problem hiding this comment.
The expected result has been corrected, which is verified by checking spark's result.
PHILO-HE
commented
Jul 14, 2022
| class ColumnarUnixTimestamp(left: Expression, right: Expression) | ||
| extends UnixTimestamp(left, right) with | ||
| ColumnarExpression { | ||
|
|
||
| val yearMonthDayFormat = "yyyy-MM-dd" |
There was a problem hiding this comment.
After double check, castDATE_nullsafe currently still cannot handle no separator date format, i.e., yyyyMMdd, as before. Let's enable it if there is a requirement from users.
| val timestampNode = TreeBuilder.makeFunction("castTIMESTAMP", | ||
| Lists.newArrayList(ConverterUtils.addTimestampOffset(tsInMilliSecNode)), timestampType) | ||
| // The largest length for yyyy-MM-dd HH:mm:ss. | ||
| val lenNode = TreeBuilder.makeLiteral(java.lang.Long.valueOf(19L)) |
There was a problem hiding this comment.
The length (19) is set for the output string length. It's a fixed value for 'yyyy-MM-dd HH:mm:ss' format.
This reverts commit 11f0977.
zhouyuan
approved these changes
Jul 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enhancement and fixing bugs.
How was this patch tested?
Query test with designed case. Some spark UTs also covers.