[NSE-42] early release sort input (#43)

* early close sort input to reduce memory footprint Signed-off-by: Yuan Zhou <yuan.zhou@intel.com> * remove double close Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
oap-project · Jan 18, 2021 · c907202 · c907202
1 parent 1c4a4e5
commit c907202
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/core/src/main/scala/com/intel/oap/expression/ColumnarSorter.scala b/core/src/main/scala/com/intel/oap/expression/ColumnarSorter.scala
@@ -92,7 +92,6 @@ class ColumnarSorter(
     elapse.set(NANOSECONDS.toMillis(total_elapse))
     sortTime.set(NANOSECONDS.toMillis(sort_elapse))
     shuffleTime.set(NANOSECONDS.toMillis(shuffle_elapse))
-    inputBatchHolder.foreach(cb => cb.close())
     if (sorter != null) {
       sorter.close()
     }
@@ -153,7 +152,12 @@ class ColumnarSorter(
           sort_elapse += System.nanoTime() - beforeSort
           total_elapse += System.nanoTime() - beforeSort
         }
-        sort_iterator.hasNext()
+        if (sort_iterator.hasNext()) {
+          return true
+        } else {
+          inputBatchHolder.foreach(cb => cb.close())
+          return false
+        }
       }
 
       override def next(): ColumnarBatch = {