fix decimal isEmpty

oap-project · Aug 11, 2021 · bff3bf8 · bff3bf8
1 parent 628329d
commit bff3bf8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...ne/core/src/test/scala/org/apache/spark/sql/nativesql/NativeDataFrameAggregateSuite.scala b/...ne/core/src/test/scala/org/apache/spark/sql/nativesql/NativeDataFrameAggregateSuite.scala
@@ -41,7 +41,7 @@ class NativeDataFrameAggregateSuite extends QueryTest
 
   val absTol = 1e-8
 
-  ignore("groupBy") {
+  test("groupBy") {
     checkAnswer(
       testData2.groupBy("a").agg(sum($"b")),
       Seq(Row(1, 3), Row(2, 3), Row(3, 3))

diff --git a/native-sql-engine/cpp/src/codegen/arrow_compute/ext/actions_impl.cc b/native-sql-engine/cpp/src/codegen/arrow_compute/ext/actions_impl.cc
@@ -2095,7 +2095,7 @@ class SumActionPartial<DataType, CType, ResDataType, ResCType,
         builder_isempty_->Append(true);
       } else {
         builder_->AppendNull();
-        builder_isempty_->AppendNull();
+        builder_isempty_->Append(false);
       }
     }
     RETURN_NOT_OK(builder_->Finish(&arr_out));
@@ -2118,7 +2118,7 @@ class SumActionPartial<DataType, CType, ResDataType, ResCType,
         builder_isempty_->Append(true);
       } else {
         builder_->AppendNull();
-        builder_isempty_->AppendNull();
+        builder_isempty_->Append(false);
       }
     }
     RETURN_NOT_OK(builder_->Finish(&arr_out));