fix memleak

oap-project · Jun 25, 2021 · 46d7465 · 46d7465
1 parent bb3c5ef
commit 46d7465
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/...-sql-engine/core/src/main/scala/com/intel/oap/expression/ColumnarConditionProjector.scala b/...-sql-engine/core/src/main/scala/com/intel/oap/expression/ColumnarConditionProjector.scala
@@ -287,9 +287,9 @@ class ColumnarConditionProjector(
                     // This projector is used to do filtering only.
                     val filteProjector = createProjector(
                       resultArrowSchema, resultArrowSchema, filterPrepareList, withCond)
-                    val outputBatch = filteProjector.evaluate(
-                      ConverterUtils.createArrowRecordBatch(columnarBatch),
-                      numRows, selectionVector)
+                    val cb = ConverterUtils.createArrowRecordBatch(columnarBatch)
+                    val outputBatch = filteProjector.evaluate(cb, numRows, selectionVector)
+                    ConverterUtils.releaseArrowRecordBatch(cb)
                     resColumnarBatch = outputBatch
                   }
                 }

diff --git a/native-sql-engine/cpp/src/codegen/arrow_compute/ext/conditioned_probe_kernel.cc b/native-sql-engine/cpp/src/codegen/arrow_compute/ext/conditioned_probe_kernel.cc
@@ -897,7 +897,8 @@ class ConditionedProbeKernel::Impl {
      * If this config is false, there are three cases:
       (1) If key from stream side contains null, this row will be joined;
       (2) Else if the key from stream side cannot be found in build side, this row will be
-    joined; (3) Else the key from stream side does not statisfy the condition, this row
+    joined;
+      (3) Else the key from stream side does not statisfy the condition, this row
     will be joined.
     */