Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1155] Move target compose definition in packit.yaml #907

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

danmyway
Copy link
Member

@danmyway danmyway commented Sep 8, 2023

Jira Issues: RHELC-1155

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

* with changes in packit/packit-service#2168 we can now move the
  targeted OS back under the distros key

Signed-off-by: Daniel Diblik <ddiblik@redhat.com>
@danmyway
Copy link
Member Author

danmyway commented Sep 8, 2023

The changes are not yet in the production, as per this comment packit/packit-service#2072 (comment) it should land in the production Tue, Sep 12th '23.
I will validate and test the configuration then.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5b720b9) 94.01% compared to head (d9069eb) 94.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #907   +/-   ##
=======================================
  Coverage   94.01%   94.01%           
=======================================
  Files          41       41           
  Lines        4142     4142           
  Branches      737      737           
=======================================
  Hits         3894     3894           
  Misses        177      177           
  Partials       71       71           
Flag Coverage Δ
centos-linux-7 89.37% <ø> (ø)
centos-linux-8 89.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@danmyway danmyway changed the title Move target compose definition [DRAFT - DO NOT MERGE] Move target compose definition Sep 8, 2023
@danmyway
Copy link
Member Author

/packit test --labels non-destructive

@danmyway danmyway added skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/all Run the full test suite. Equivalent to `/packit test`. labels Sep 13, 2023
@danmyway danmyway marked this pull request as ready for review September 13, 2023 11:49
@has-bot
Copy link
Member

has-bot commented Sep 13, 2023

/packit test


@oamg/conversions-qe please review results and provide ack.

@danmyway danmyway changed the title [DRAFT - DO NOT MERGE] Move target compose definition [RHELC-1155] Move target compose definition Sep 13, 2023
@danmyway danmyway changed the title [RHELC-1155] Move target compose definition [RHELC-1155] Move target compose definition in packit.yaml Sep 13, 2023
@danmyway danmyway requested a review from kokesak September 14, 2023 08:02
@danmyway danmyway merged commit 2b75603 into oamg:main Sep 14, 2023
hosekadam pushed a commit to hosekadam/convert2rhel that referenced this pull request Oct 2, 2023
* with changes in packit/packit-service#2168 we can now move the
  targeted OS back under the distros key

Signed-off-by: Daniel Diblik <ddiblik@redhat.com>
Andrew-ang9 pushed a commit to Andrew-ang9/convert2rhel that referenced this pull request Oct 10, 2023
* with changes in packit/packit-service#2168 we can now move the
  targeted OS back under the distros key

Signed-off-by: Daniel Diblik <ddiblik@redhat.com>
@danmyway danmyway deleted the tweak-targets-for-packit branch September 3, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/all Run the full test suite. Equivalent to `/packit test`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants