[RHELC-1626] Use no_rhsm to detect if enablerepos should be disabled #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1289 +/- ##
=======================================
Coverage 95.84% 95.84%
=======================================
Files 55 55
Lines 4768 4771 +3
Branches 839 840 +1
=======================================
+ Hits 4570 4573 +3
Misses 112 112
Partials 86 86
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bocekm
requested changes
Jul 3, 2024
bocekm
approved these changes
Jul 4, 2024
r0x0d
added
kind/bug-fix
bookwar
force-pushed
the
disable-use-of-enablerepos-in-excluded-pkgs-action
branch
from
0b68428 to
7b7af2e
Compare
|
/packit test --labels tier0 |
2 similar comments
|
/packit test --labels tier0 |
|
/packit test --labels tier0 |
r0x0d
force-pushed
the
disable-use-of-enablerepos-in-excluded-pkgs-action
branch
from
7b7af2e to
e38719a
Compare
|
/packit test --labels tier0 |
hosekadam
approved these changes
Jul 11, 2024
|
Couldn't test (outage of the Candlepin), but the changes look good. |
|
/packit test --labels tier0 |
1 similar comment
|
/packit test --labels tier0 |
We have a special function that returns a list of repositories that needs to be disabled during various command calls, and that list is returning always the user enablerepos command line switch in it. This patch only add the enablerepos option to the list when the --no-rhsm switch is also applied.
Co-authored-by: Michal Bocek <mbocek@redhat.com>
Venefilyn
force-pushed
the
disable-use-of-enablerepos-in-excluded-pkgs-action
branch
from
e38719a to
16d354e
Compare
|
/packit test --labels tier0 |
This was referenced Aug 21, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a special function that returns a list of repositories that needs to be disabled during various command calls, and that list is returning always the user enablerepos command line switch in it. This patch only add the enablerepos option to the list when the --no-rhsm switch is also applied.
Jira Issues:
Checklist
[RHELC-]or[HMS-]is part of the PR titleRelease Pendingif relevant